Skip to content

Conversation

upachler
Copy link
Contributor

@upachler upachler commented Oct 4, 2024

I took the liberty and added some docs, hope this meets the requirements.

@ahl
Copy link
Collaborator

ahl commented Nov 25, 2024

Let's update this in light of #933?

@upachler
Copy link
Contributor Author

upachler commented Nov 26, 2024

Hi @ahl, I adapted the docs as promised. However, apparently cargo fmt -- --check is now complaining about style (see below) - but I can't see anything wrong. When run locally, there is no output. I'm puzzled. Any clues? Or is this a Windows/Linux thing (I'm using a Windows machine ATM).

@ahl
Copy link
Collaborator

ahl commented Nov 26, 2024

You can run cargo fmt and it will fix things. In this case, you have trailing spaces at the end of some lines.

@upachler
Copy link
Contributor Author

ok thanks, seems that did it

@upachler
Copy link
Contributor Author

@ahl: IMHO this should be ready to merge, what do you think?

@upachler
Copy link
Contributor Author

Updated to resolve merge conflict.
@ahl Waiting for authorization. This is a documenation improvement, no code change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants