Per-entrypoint DevMaps
#710
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accidentally over-counted by the ETH header, and illumos is sending down chunks of size n×MSS. This would split one TSO packet into three (versus baseline two).
Needed for older propolis (falcon), which does not preallocate sufficient headroom for us to push into.
This makes sure that if we're receiving a packet which has benefited from real/pseudo GRO, viona is able to split it up if the guest can't actually take those packets.
Goodbye CI, I knew thee well.
Back to target perf.
At the very least, this compiles. We needed to regenerate `ip.rs`, on account of the many `extern` -> `unsafe extern` block changes.
CI on recent PRs is breaking, due to rustup 1.28.0+ no longer autoinstalling the correct rust toolchain version. This hurts us immediately since we have *two* toolchains (pinned nightly and stable), and deliberately specified the nightly for some tooling. This PR changes this over to use buildomat's auto-installation for the stable variant, and the new toolchain show -> install pattern for nightly. This also lets us place `$NIGHTLY` into most of our `cargo fmt` invocations, which should reduce the busywork in future compiler bumps for XDE.
We still have a hilarious failure to remove resources *somewhere*, causing havoc on underlay removal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XXX WIP
Closes #689.