Blueprint planner/builder: require reason when accessing expunged zones (#9608) #9633
+373
−237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using jj-spr 0.1.0
mergeconflict
deleted the
spr/mergeconflict/blueprint-plannerbuilder-require-reason-when-accessing-expunged-zones-9608
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #9521, specifically driven by @smklein's
note
that the planner also accesses expunged zones, and we need to track
those reasons too. Doing this work revealed one case where the planner
was accessing them in a way that was going to cause problems with
pruning; that's fixed by #9550, and this PR is staged on top of it.