Skip to content

Collect internal DNS generation in inventory #8643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
Merged

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Jul 18, 2025

Fixes #8544

Copy link
Contributor

@jgallagher jgallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also update the inventory display implementation? Should be easy now that #8613 has landed.

@smklein smklein force-pushed the inventory-collect-timesync branch 3 times, most recently from c16686f to bea6e02 Compare July 21, 2025 19:15
@smklein smklein force-pushed the inventory-collect-dns branch from a7dca86 to e7f1843 Compare July 21, 2025 19:43
@smklein smklein force-pushed the inventory-collect-timesync branch from bea6e02 to 5f2c4dd Compare July 21, 2025 21:39
@smklein smklein force-pushed the inventory-collect-dns branch 3 times, most recently from 1fc3373 to 9fda2da Compare July 22, 2025 00:53
@smklein
Copy link
Collaborator Author

smklein commented Jul 22, 2025

Can we also update the inventory display implementation? Should be easy now that #8613 has landed.

Updated nexus/types/src/inventory/display.rs to include this

Base automatically changed from inventory-collect-timesync to main July 22, 2025 02:36
@smklein smklein force-pushed the inventory-collect-dns branch 2 times, most recently from 1c5a033 to 189ec3d Compare July 22, 2025 18:48
pub fn new(
creator: &str,
mgs_clients: Vec<gateway_client::Client>,
keeper_admin_clients: Vec<clickhouse_admin_keeper_client::Client>,
cockroach_admin_client: &'a CockroachClusterAdminClient,
ntp_admin_clients: Vec<(OmicronZoneUuid, ntp_admin_client::Client)>,
dns_service_clients: Vec<(OmicronZoneUuid, dns_service_client::Client)>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't change this on this PR (or maybe at all), but just thinking out loud - would it make sense for ntp_admin_client and dns_service_client to wrap the progenitor Client in something that holds an OmicronZoneUuid? It could impl Deref so you could call all the normal client methods, but also say client.zone_id().

I guess that would force every client to look up the zone ID, which maybe they don't care about. It could expose both the existing Client and a ClientWithZoneId I guess? Maybe that's not really worth it.

@smklein smklein force-pushed the inventory-collect-dns branch 3 times, most recently from 789b66f to 506ab20 Compare July 23, 2025 22:18
@smklein smklein force-pushed the inventory-collect-dns branch from 506ab20 to 0df7e2b Compare July 24, 2025 16:49
@smklein smklein enabled auto-merge (squash) July 24, 2025 16:51
@smklein smklein merged commit ee20d9b into main Jul 24, 2025
17 checks passed
@smklein smklein deleted the inventory-collect-dns branch July 24, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

want internal DNS server generation in inventory
2 participants