add information about SP-related updates to blueprint#7975
Merged
davepacheco merged 11 commits intomainfrom Apr 16, 2025
Merged
add information about SP-related updates to blueprint#7975davepacheco merged 11 commits intomainfrom
davepacheco merged 11 commits intomainfrom
Conversation
This was referenced Apr 15, 2025
jgallagher
approved these changes
Apr 15, 2025
Contributor
jgallagher
left a comment
There was a problem hiding this comment.
LGTM, mostly just questions about followup work
Collaborator
Author
|
Thanks for the review! I'm tracking all the follow-up work in the Reconfigurator board but I'm happy to make sure real (non-draft) issues are filed and maybe note them in the comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first cut of adding information about SP-related updates to the blueprint.
(copied from #7741 and edited because this is basically an update of that PR)
The plan is that the blueprint will maintain a list of pending MGS-managed updates. An MGS-managed update is any update done by the SP and controlled via MGS, which means: RoT bootloader, RoT Hubris image, SP Hubris image, and host phase 1. There may be at most one of these pending for any baseboard at once, but there could be multiple baseboards getting an update at once. (A baseboard is a thing with an SP on it: Gimlet, Sidecar, or PSC.)
When the planner wants to update one of these things, it will add a PendingMgsUpdate to the (next) blueprint. When it notices that the inventory reflects that that change has been made, it removes it from the (next) blueprint.
See #7976 for the bigger picture (PRs ahead of and behind this one).
Depends on #7974.