[gateway] update MGS Git dependency #7924
Conversation
It turns out that our Git dependency on the oxidecomputer/management-gateway-service repo hasn't been updated in... a while. We're currently on a commit from September of last year, oxidecomputer/management-gateway-service@9bbac47. This branch updates it to the current HEAD commit, oxidecomputer/management-gateway-service@f9566e6. The only changes in MGS that required code changes in Omicron are: - oxidecomputer/management-gateway-service#291, where I added a new `MeasurementKind` for AMD CPU T<sub>ctl</sub> values (which are not temperatures in degrees Celcius, but a secret third thing). - oxidecomputer/management-gateway-service#316 by @mkeeter, adding the interface to read SP task dumps over the network. Since this adds methods to the `sp_impl::SpHandler` trait, the SP simulator implementations need to be updated, or else they will no longer compile. For now, I've just made these `unimplemented!()`, as we're not currently actually _using_ them. In my PR #7903 implementing ereport ingestion from SPs, I had to make these changes as part of changing the MGS dependency to pull in the new `gateway-sp-comms` code for ereports. Since this isn't actually related, and is just necessary to update the Git dep, I figured I'd pull that commit (49973ae) into its own PR.
There was a problem hiding this comment.
Sorry! I had done most of this in #7666, but meant to follow up with you on the CpuTctl stuff to see if I had updated that correctly and never did. I'll close that in favor of this one; the changes are almost the same (left a couple comments where they differed) but this one is pointing to a newer commit.
Test failures probably a one-line change to nexus/tests/integration_tests/metrics.rs?
sp-sim/src/gimlet.rs
Outdated
| @@ -1502,6 +1504,28 @@ impl SpHandler for Handler { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| fn get_task_dump_count(&mut self) -> Result<u32, SpError> { | |||
| unimplemented!() | |||
There was a problem hiding this comment.
I'd replace these with returning "not supported" errors, I think. (That's what I did on #7666.)
Co-authored-by: John Gallagher <[email protected]>
Ah, whoops, I didn't notice that branch when I went and did this! Thanks for the review! |
|
...oh, looking at #7666, it seems like you did tag me and I approved it, but then the branch stalled out for some other reason, I guess? |
It turns out that our Git dependency on the
oxidecomputer/management-gateway-service repo hasn't been updated in... a while. We're currently on a commit from September of last year, oxidecomputer/management-gateway-service@9bbac47. This branch updates it to the current HEAD commit, oxidecomputer/management-gateway-service@f9566e6.
The only changes in MGS that required code changes in Omicron are:
MeasurementKind::Dimensionlessmanagement-gateway-service#291, where I added a newMeasurementKindfor AMD CPU Tctl values (which are not temperatures in degrees Celcius, but a secret third thing).sp_impl::SpHandlertrait, the SP simulator implementations need to be updated, or else they will no longer compile. For now, I've just made theseunimplemented!(), as we're not currently actually using them.In my PR #7903 implementing ereport ingestion from SPs, I had to make these changes as part of changing the MGS dependency to pull in the new
gateway-sp-commscode for ereports. Since this isn't actually related, and is just necessary to update the Git dep, I figured I'd pull that commit (49973ae) into its own PR.