[2/n] [nexus-db-schema] make HAS_STATIC_QUERY_ID true for all enums #7897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1 [skip ci]
smklein
approved these changes
Apr 1, 2025
sunshowers
changed the base branch from
sunshowers/spr/main.2n-nexus-db-schema-make-has_static_query_id-true-for-all-enums
to
main
sunshowers
deleted the
sunshowers/spr/2n-nexus-db-schema-make-has_static_query_id-true-for-all-enums
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to be false if and only if types don't match 1:1 to queries, e.g. with CTEs. These types do match 1:1 to queries, so using
HAS_STATIC_QUERY_IDshould be fine.There's a small possibility some code was inadvertently depending on
HAS_STATIC_QUERY_IDbeing false, but tests should hopefully catch that.Depends on #7880.