Don't panic when piping #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The print! family of macros will panic if they fail to write to stdout/stderr. This condition occurs quite commonly in the terminal when piping to `head(1)`, and displays a messy panic message to the user. Convert all output to use write!, and ignore any EPIPE errors.
|
I just checked, and it remains truly and utterly deranged that the Rust project has been unable to get both arms around the problem of not screwing up SIGPIPE handling on UNIX systems in at least five years; e.g., I think rather than rewrite all the I/O to work around this, I'll just work around it with the sigpipe crate for now. I'll get that sorted this afternoon! |
|
That's neat. Maybe we should use that in the CLI |
|
I put back the sigpipe change: 2d641e8 I've also published an updated Helios package: I've also updated atrium to have this version. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The print! family of macros will panic if they fail to write to stdout/stderr. This condition occurs quite commonly in the terminal when piping to
head(1), and displays a messy panic message to the user.Convert all output to use write!, and ignore any EPIPE errors.