Basic crate for accessing task names at build time. #2052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
approved these changes
Apr 29, 2025
sys/task-names/build.rs
Outdated
Comment on lines
19
to
26
| for name in &task_names { | ||
| writeln!(task_file, " {name:?},").unwrap(); | ||
| } | ||
| writeln!(task_file, "];").unwrap(); | ||
|
|
||
| let longest = task_names.iter().map(|s| s.len()).max() | ||
| .unwrap_or(0); | ||
| writeln!(task_file, "pub const MAX_TASK_NAME: usize = {longest};").unwrap(); |
There was a problem hiding this comment.
Normally I might suggest the use of quote! rather than manually writeln!ing Rust source strings in new code, but...this is so trivial I dunno if I care. 🤷♀️
There was a problem hiding this comment.
This is actually the ideal lib.rs.
There was a problem hiding this comment.
idk, it could have more comments.
cbiffle
force-pushed
the
cbiffle/task-names
branch
from
829d54c to
8f52d8e
Compare
aapoalas
reviewed
Apr 29, 2025
sys/task-names/src/lib.rs
Outdated
| //! | ||
| //! `TASK_NAMES` is a `static` array of `&str`. | ||
| //! | ||
| //! `MASK_TASK_NAME` is a `const` `usize` giving the number of bytes in the |
There was a problem hiding this comment.
typo:
Suggested change
| //! `MASK_TASK_NAME` is a `const` `usize` giving the number of bytes in the | |
| //! `MAX_TASK_NAME` is a `const` `usize` giving the number of bytes in the |
This allows tasks to refer to other tasks by name, which we need _very rarely,_ but has come up for fault reporting.
cbiffle
force-pushed
the
cbiffle/task-names
branch
from
8f52d8e to
53d5022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows tasks to refer to other tasks by name, which we need very rarely, but has come up for fault reporting.