Skip to content

Tofino dependencies #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: helios2
Choose a base branch
from
Open

Tofino dependencies #25

wants to merge 6 commits into from

Conversation

Nieuwejaar
Copy link

This adds two packages that are needed to build the tofino SDE. The CI scripts for that build are currently pulling pre-built packages from an S3 bucket, but it would be cleaner and more sustainable if they could be pulled from the helios package repo instead.

@Nieuwejaar Nieuwejaar requested a review from citrus-it March 4, 2025 16:41
@citrus-it
Copy link
Collaborator

citrus-it commented Mar 6, 2025

I've pushed some changes that tweak things a bit and get this closer to something we could upstream to OmniOS, which would make future helios updates easier.

This consists of:

  • use the supplied functions like set_arch and set_builddir as they have other side effects;
  • build both 32-bit and 64-bit abseil versions and install into the standard location (which was previously prevented by protobuf);
  • fix protobuf to use the abseil package and stop delivering its own copy;
  • fix a couple of build errors in boost and revert the small change to lib/functions.sh so we don't diverge there.

@Nieuwejaar please take a look. I suspect the build failures just weren't noticed previously as the exit status of b2 was not being checked. They've already been fixed upstream and we can carry a patch for now.

@jclulow
Copy link
Collaborator

jclulow commented Apr 1, 2025

I'm curious about the ABI stability of these things, as the versions go up. Do you have a sense of whether abseil or boost remain backwards compatible as they release new versions?

@bnaecker
Copy link

bnaecker commented Apr 1, 2025

On that front, the oxide/build.sh script we're using hard-codes a CMake variable to using a local copy of Abseil. But one could download it from a specific source revision for the build itself, which we might want to do for ABI compatibility reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants