-
Notifications
You must be signed in to change notification settings - Fork 2
add support for v4 routes over v6 nexthops #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
1021886
ea3b08c
079412b
1f90203
0ab6730
6a1906d
8f12cea
e7af427
1913ab4
ffd3aa9
496284e
9c64db1
a79e198
0d88485
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| // This Source Code Form is subject to the terms of the Mozilla Public | ||
| // License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| // file, You can obtain one at https://mozilla.org/MPL/2.0/ | ||
| // | ||
| // Copyright 2026 Oxide Computer Company | ||
|
|
||
| use dpd_types::route::Ipv4Route; | ||
| use oxnet::Ipv4Net; | ||
| use schemars::JsonSchema; | ||
| use serde::{Deserialize, Serialize}; | ||
|
|
||
| /// Represents all mappings of an IPv4 subnet to a its nexthop target(s). | ||
| #[derive(Debug, Clone, Deserialize, Serialize, JsonSchema)] | ||
| pub struct Ipv4Routes { | ||
| /// Traffic destined for any address within the CIDR block is routed using | ||
| /// this information. | ||
| pub cidr: Ipv4Net, | ||
| /// All RouteTargets associated with this CIDR | ||
| pub targets: Vec<Ipv4Route>, | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,7 +71,7 @@ All environment variables are prefixed by `DENDRITE_TEST_` for clarity. | |
| representation of packets on failure. The second bit controls whether to | ||
| display the hex of each packet body as well. | ||
| - `DENDRITE_TEST_TIMEOUT`: The amount of time to wait for any single test's | ||
| network traffic to complete, specified in milliseconds. The default is 500, | ||
| network traffic to complete, specified in milliseconds. The default is 1500, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I never (almost never?) hit this in CI. When running on the colo, 500ms works for everything except a single multicast test. I'd rather not change the default if it's just failing on a single machine somewhere, since it seems like it could tripe the time it takes to run the tests.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've hit what I believe is this several times in CI recently, i would even characterize it as hitting often. It also happens for me regularly on a development VM.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I suspect any timing issues you hit in CI were #172. |
||
| which works for a reasonably powerful system under light load. | ||
|
|
||
| ## Parallelization | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never seen this be an issue before. Are you seeing this in CI or somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it regularly when running the tests locally on a development VM.