Audit Log #2849
Merged
Audit Log #2849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benjaminleonard
commented
Jul 8, 2025
| @@ -101,7 +101,7 @@ export const Listbox = <Value extends string = string>({ | |||
| id={id} | |||
| name={name} | |||
| className={cn( | |||
| `flex h-11 items-center justify-between rounded border text-sans-md`, | |||
| `flex h-10 items-center justify-between rounded border text-sans-md`, | |||
There was a problem hiding this comment.
Sneaking in my continued densification
Since oxidecomputer/omicron#8527 the control plane has been happy to accept such sizes.
* Update pinned Omicron version * Update mock data; update filters list to show type / code in badge list * Updating form to handle ICMP types; UI not there yet; also needs ICMP codes sub-option * oops; license * Updates to handle proper protocol objects in the form * prevent duplicate protocols; convert mini table to columns showing protocol, type, code * add ProtocolBadge component * refactor; update tests * Refactoring and usability improvements * small tweaks * ProtocolCell and friends * Move away from badges in mini table for type and code * update Protocol Badge layout * a few more ProtocolBadge adjustments * Update test to account for new badge * Properly handle selective code combobox display * slight refactoring * refactoring * add icmp filter to the mock rule with lots of filters * try "parse, don't validate" on ICMP type * combobox values can't be numbers * tweak help copy * Bump Omicron and add new IP Pool column to networking table (#2855) * Bump Omicron further and add IP Pool ID column to networking tab * simplify IP Pool finding with safer fallback * Bump Omicron to latest and run gen-api; no changes to console * give IpPoolCell loading state, don't blow up on errors * A few post-review adjustments * Simpler handling of resolveIpPool * small type refactor * shorter getIpFromPool --------- Co-authored-by: David Crespo <[email protected]> * bind icmp type input value to form value --------- Co-authored-by: David Crespo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still very rough, but has been a helpful exercise in working through some of the design due to the sheer amount of information and differing layout from other pages.
Stubbing out based on oxidecomputer/omicron#7339.
Uses Tanstack Virtual. On testing with > 500 lines it starts to get a bit chunky especially if you're interacting with the page (e.g. opening the row).
Hoping that silo name and actor display name can be plumbed through so those are hard-coded for now.
Still needs: