Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minifier): merge similar if stmts #8509

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Jan 15, 2025

No description provided.

@github-actions github-actions bot added the A-minifier Area - Minifier label Jan 15, 2025
Copy link
Contributor Author

camc314 commented Jan 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Jan 15, 2025
Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #8509 will degrade performances by 33.75%

Comparing c/01-15-feat_minifier_merge_similar_if_stmts (62a3dac) with main (7e61b23)

Summary

❌ 1 regressions
✅ 31 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main c/01-15-feat_minifier_merge_similar_if_stmts Change
minifier[typescript.js] 332 ms 501.1 ms -33.75%

@camc314 camc314 requested a review from Boshen January 15, 2025 14:44
@camc314 camc314 force-pushed the c/01-15-feat_minifier_merge_similar_if_stmts branch 2 times, most recently from b5e1fb0 to 934c75c Compare January 15, 2025 15:06
@camc314 camc314 marked this pull request as ready for review January 15, 2025 15:06
@Boshen
Copy link
Member

Boshen commented Jan 15, 2025

-33.76%

this is not good.

@Boshen Boshen marked this pull request as draft January 15, 2025 15:28
@camc314 camc314 force-pushed the c/01-15-feat_minifier_merge_similar_if_stmts branch from 934c75c to 72fa9df Compare January 15, 2025 15:32
@camc314 camc314 force-pushed the c/01-15-feat_minifier_merge_similar_if_stmts branch from 72fa9df to 62a3dac Compare January 15, 2025 15:38
@camc314
Copy link
Contributor Author

camc314 commented Jan 15, 2025

hmm most of the perf impact is via using ContentEq to compare the content of the if alternate/consequent

@camc314 camc314 mentioned this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-minifier Area - Minifier C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants