refactor(linter/prefer_function_type): simplify handling comments

[Dunqing]

Found this weird while working on #16479

[Dunqing]

• refactor(linter/prefer_function_type): simplify handling comments #16722 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

This PR refactors the comment handling logic in the prefer_function_type TypeScript linter rule to make it simpler and more concise. The refactoring removes unnecessary intermediate steps while maintaining the same functionality.

Key changes:

• Simplified comment iteration by using peekable() to check for comments instead of a separate has_comments_between() call
• Eliminated manual reconstruction of comment delimiters by using the full comment span directly
• Reduced code from ~30 lines to ~9 lines while preserving identical output

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

CodSpeed Performance Report

Merging #16722 will not alter performance

_{Comparing 12-11-refactor_linter_prefer_function_type_simplify_handling_comments (cf53115) with main (afd6c44)¹}

Summary

✅ 4 untouched
⏩ 41 skipped²

Footnotes

1. No successful run was found on main (ef1ef18) during the generation of this report, so afd6c44 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[camchenry]

Merge activity

• Dec 11, 4:21 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 11, 5:21 AM UTC: camchenry added this pull request to the Graphite merge queue.
• Dec 11, 5:26 AM UTC: Merged by the Graphite merge queue.