Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 8, 2025

Pure refactor. "writable" is the correct spelling. Correct "writeable" to "writable" in a few places.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 8, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review December 8, 2025 18:48
Copilot AI review requested due to automatic review settings December 8, 2025 18:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the spelling from "writeable" to "writable" across the class properties transformer. The change affects the method name find_writable_private_prop, its documentation, and all call sites, ensuring consistency with standard English spelling throughout the codebase.

Key Changes

  • Renamed method find_writeable_private_prop to find_writable_private_prop in ClassesStack
  • Updated all method calls to use the corrected spelling
  • Updated documentation comments to reflect the correct spelling

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
crates/oxc_transformer/src/es2022/class_properties/private_method.rs Updated method call to use find_writable_private_prop
crates/oxc_transformer/src/es2022/class_properties/private_field.rs Updated method call to use find_writable_private_prop
crates/oxc_transformer/src/es2022/class_properties/class_details.rs Renamed method definition and updated documentation comments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 8, 2025

CodSpeed Performance Report

Merging #16615 will improve performances by 3.03%

Comparing 12-08-refactor_transformer_correct_spelling (289a51c) with main (913b1b3)1

Summary

⚡ 1 improvement
✅ 37 untouched
⏩ 7 skipped2

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
Simulation minifier[cal.com.tsx] 37.1 ms 36 ms +3.03%

Footnotes

  1. No successful run was found on main (f669d4a) during the generation of this report, so 913b1b3 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Dec 9, 2025
Copy link
Member

Dunqing commented Dec 9, 2025

Merge activity

Pure refactor. "writable" is the correct spelling. Correct "writeable" to "writable" in a few places.
@graphite-app graphite-app bot force-pushed the 12-08-refactor_transformer_correct_spelling branch from 289a51c to 847d468 Compare December 9, 2025 00:38
@graphite-app graphite-app bot merged commit 847d468 into main Dec 9, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 12-08-refactor_transformer_correct_spelling branch December 9, 2025 00:44
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 9, 2025
Copilot AI pushed a commit that referenced this pull request Dec 10, 2025
Pure refactor. "writable" is the correct spelling. Correct "writeable" to "writable" in a few places.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants