-
-
Notifications
You must be signed in to change notification settings - Fork 737
chore(lsp): rename remove_diagnostics to remove_uri_cache
#16614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lsp): rename remove_diagnostics to remove_uri_cache
#16614
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
e7464ea to
9b03da9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR performs a simple refactoring to rename the remove_diagnostics method to remove_uri_cache across the language server codebase. The new name better reflects that the method removes internal cached data (specifically code actions) rather than just diagnostics, improving code clarity and maintainability.
Key changes:
- Renamed
remove_diagnosticstoremove_uri_cachein theTooltrait and all its implementations - Updated method documentation to clarify that it removes internal cache rather than diagnostics
- No logic changes, purely a naming improvement
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/oxc_language_server/src/tool.rs |
Updated the Tool trait method name and documentation from remove_diagnostics to remove_uri_cache |
crates/oxc_language_server/src/worker.rs |
Updated the WorkspaceWorker method name and documentation to match the trait change |
crates/oxc_language_server/src/linter/server_linter.rs |
Updated the ServerLinter implementation of the trait method |
crates/oxc_language_server/src/backend.rs |
Updated the call site in did_close to use the new method name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merge activity
|
Renaming the method to make it more clear. There is no diagnostic anymore to be removed. Instead remove the cache of an given URI.
9b03da9 to
22fdc4a
Compare
Renaming the method to make it more clear. There is no diagnostic anymore to be removed. Instead remove the cache of an given URI.

Renaming the method to make it more clear.
There is no diagnostic anymore to be removed. Instead remove the cache of an given URI.