Skip to content

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Dec 8, 2025

Renaming the method to make it more clear.
There is no diagnostic anymore to be removed. Instead remove the cache of an given URI.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 8, 2025
Copy link
Member Author

Sysix commented Dec 8, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix force-pushed the 12-08-chore_lsp_rename_remove_diagnostics_to_remove_uri_cache_ branch from e7464ea to 9b03da9 Compare December 8, 2025 18:31
@Sysix Sysix marked this pull request as ready for review December 8, 2025 18:31
@Sysix Sysix requested a review from camc314 as a code owner December 8, 2025 18:31
Copilot AI review requested due to automatic review settings December 8, 2025 18:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs a simple refactoring to rename the remove_diagnostics method to remove_uri_cache across the language server codebase. The new name better reflects that the method removes internal cached data (specifically code actions) rather than just diagnostics, improving code clarity and maintainability.

Key changes:

  • Renamed remove_diagnostics to remove_uri_cache in the Tool trait and all its implementations
  • Updated method documentation to clarify that it removes internal cache rather than diagnostics
  • No logic changes, purely a naming improvement

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
crates/oxc_language_server/src/tool.rs Updated the Tool trait method name and documentation from remove_diagnostics to remove_uri_cache
crates/oxc_language_server/src/worker.rs Updated the WorkspaceWorker method name and documentation to match the trait change
crates/oxc_language_server/src/linter/server_linter.rs Updated the ServerLinter implementation of the trait method
crates/oxc_language_server/src/backend.rs Updated the call site in did_close to use the new method name

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@camc314 camc314 self-assigned this Dec 8, 2025
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 8, 2025
Copy link
Contributor

camc314 commented Dec 8, 2025

Merge activity

Renaming the method to make it more clear.
There is no diagnostic anymore to be removed. Instead remove the cache of an given URI.
@graphite-app graphite-app bot force-pushed the 12-08-chore_lsp_rename_remove_diagnostics_to_remove_uri_cache_ branch from 9b03da9 to 22fdc4a Compare December 8, 2025 23:00
@graphite-app graphite-app bot merged commit 22fdc4a into main Dec 8, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 12-08-chore_lsp_rename_remove_diagnostics_to_remove_uri_cache_ branch December 8, 2025 23:05
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 8, 2025
Copilot AI pushed a commit that referenced this pull request Dec 10, 2025
Renaming the method to make it more clear.
There is no diagnostic anymore to be removed. Instead remove the cache of an given URI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants