Skip to content

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Dec 8, 2025

No description provided.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Dec 8, 2025
Copy link
Member Author

Sysix commented Dec 8, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix marked this pull request as ready for review December 8, 2025 18:00
@Sysix Sysix requested a review from camc314 as a code owner December 8, 2025 18:00
Copilot AI review requested due to automatic review settings December 8, 2025 18:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive testing for LSP server initialization with multiple workspace folders and options. The test verifies that workspace-specific options are correctly matched to their corresponding workspace folders by URI, regardless of the order in the initialization options array.

  • Refactored initialize_request function to support multiple workspace folders
  • Added new test case validating correct option-to-workspace matching across multiple folders
  • Introduced WORKSPACE_2 constant for testing scenarios with multiple workspaces

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label Dec 8, 2025
Copy link
Member Author

Sysix commented Dec 8, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 12-08-test_lsp_add_test_for_initialize_request_with_multiple_workspace_folders_options branch from 028a337 to f669d4a Compare December 8, 2025 18:04
@graphite-app graphite-app bot merged commit f669d4a into main Dec 8, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 12-08-test_lsp_add_test_for_initialize_request_with_multiple_workspace_folders_options branch December 8, 2025 18:08
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 8, 2025
Copilot AI pushed a commit that referenced this pull request Dec 10, 2025
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants