Skip to content

feat(linter): add unicorn/prefer-keyboard-event-key rule #16611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camc314 merged 3 commits into from
Dec 10, 2025
+1,649 −0
Merged

feat(linter): add unicorn/prefer-keyboard-event-key rule #16611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60aea71
feat(linter): add unicorn/prefer-keyboard-event-key rule
re-taro Dec 8, 2025
552b0da
chore: add escape to test case
re-taro Dec 9, 2025
7c241e0
u
camc314 Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions crates/oxc_linter/src/generated/rule_runner_impls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3597,6 +3597,14 @@ impl RuleRunner for crate::rules::unicorn::prefer_includes::PreferIncludes {
const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::Run;
}

impl RuleRunner for crate::rules::unicorn::prefer_keyboard_event_key::PreferKeyboardEventKey {
const NODE_TYPES: Option<&AstTypesBitset> = Some(&AstTypesBitset::from_types(&[
AstType::BindingProperty,
AstType::StaticMemberExpression,
]));
const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::Run;
}

impl RuleRunner for crate::rules::unicorn::prefer_logical_operator_over_ternary::PreferLogicalOperatorOverTernary {
const NODE_TYPES: Option<&AstTypesBitset> = Some(&AstTypesBitset::from_types(&[AstType::ConditionalExpression]));
const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::Run;
Expand Down
2 changes: 2 additions & 0 deletions crates/oxc_linter/src/rules.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,7 @@ pub(crate) mod unicorn {
pub mod prefer_event_target;
pub mod prefer_global_this;
pub mod prefer_includes;
pub mod prefer_keyboard_event_key;
pub mod prefer_logical_operator_over_ternary;
pub mod prefer_math_min_max;
pub mod prefer_math_trunc;
Expand Down Expand Up @@ -1227,6 +1228,7 @@ oxc_macros::declare_all_lint_rules! {
unicorn::prefer_top_level_await,
unicorn::prefer_at,
unicorn::prefer_global_this,
unicorn::prefer_keyboard_event_key,
unicorn::prefer_object_from_entries,
unicorn::prefer_array_find,
unicorn::prefer_array_index_of,
Expand Down
Loading
Loading