-
-
Notifications
You must be signed in to change notification settings - Fork 739
feat(transformer): Support nested member expressions in React Fast Refresh #16577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 3 commits
Commits
Show all changes
93 commits
Select commit
Hold shift + click to select a range
5c320fe
Initial plan
Copilot 635514f
feat(transformer): Support nested member expressions in React Fast Re…
Copilot 2f3b0bb
fix(transformer): Handle arbitrary nesting depth for hook member expr…
Copilot fe9c24e
refactor(parser): simplify parsing literal types (#16572)
ulrichstark efdcb6a
feat(oxfmt): Expose `setupConfig(configJSON: string)` napi callback (…
leaysgur 5df340d
refactor(oxfmt): Extract `read_to_string` as core/utils (#16581)
leaysgur 7ae42b1
feat(oxfmt): Pass raw config to prettier formatting (#16582)
leaysgur f146b6a
feat(oxfmt): Pass populated config to prettier formatting (#16584)
leaysgur 45eebbb
feat(oxfmt): Pass filepath field to prettier formatting (#16591)
leaysgur efa0098
refactor(formatter): improve printing of left-hand-side only assignme…
Dunqing d88ba88
refactor(formatter): adjust the printing implementation of BindingPro…
Dunqing ae855b9
fix(formatter): should not expand the object pattern if its parent is…
Dunqing ee96c47
fix(formatter): incorrectly treating a member chain with the test nam…
Dunqing 9ae30e3
fix(formatter): should not remove quotes for property keys that conta…
Dunqing c21e237
ci: ci.yml -> oxlint-ci.yml
Boshen 6d3a2e8
chore(deps): update dependency oxlint-tsgolint to v0.8.4 (#16597)
renovate[bot] b1edb19
fix(transformer/styled-components): named styled import doesn't work …
Dunqing b6f28db
release(crates): oxc v0.102.0 (#16595)
Boshen ee1b4fe
release(apps): oxlint v1.32.0 && oxfmt v0.17.0 (#16596)
Boshen 8102081
fix(semantic): add TS error code to constructor implementation missin…
camc314 1ef0d18
fix(semantic): add TS error code to function implementation missing d…
camc314 4603244
chore(deps): update dependency oxc-parser to ^0.102.0 (#16601)
renovate[bot] c0a5f2d
feat(linter): promote no_map_spread rule from nursery to perf (#16604)
camc314 f04bb24
chore(lsp): make tool dependencies optional (#16548)
Sysix 2fd8355
chore(deps): update dependency oxlint to v1.32.0 (#16603)
renovate[bot] 4fe400e
feat(linter): promote constructor_super rule from nursery to correctn…
camc314 18228db
chore(linter): only hyperlink rule names when docs URL exists (#16536)
Copilot 5455462
refactor(linter): rename `GlobalValue::Writeable` to `Writable` (#16609)
overlookmotel a62de4f
perf(linter/plugins): remove code for renaming global values (#16610)
overlookmotel 4f9d37d
chore(vscode): search only for `oxfmt` in the first workspace folder …
Sysix a07a066
test(lsp): add test for `initialize` request with multiple workspace …
Sysix b240f14
perf(lsp): avoid one clone in code actions request (#16543)
Sysix c3ae8fb
chore(lsp): rename `remove_diagnostics` to `remove_uri_cache` (#16614)
Sysix a700e7c
refactor(transformer): correct spelling (#16615)
overlookmotel b435ede
feat(ast, parser, codegen): add `CommentKind::MultilineBlock` (#16479)
Dunqing 5676427
refactor(formatter): simplify checking multiline block comment (#16481)
Dunqing e4b31c1
chore(deps): update rust crates (#16575)
renovate[bot] 69dafd8
feat(oxfmt): trace which files are being formatted via `OXC_LOG=debug…
Boshen d682403
perf(oxfmt): Use `worker_threads` by `tinypool` for prettier formatti…
leaysgur 8d19746
fix(formatter): disable layout assertions on some 32-bit platforms (#…
Dunqing f3ee5ad
fix(oxfmt): Exclude lock files to be formatted (#16629)
leaysgur fca3327
fix(oxfmt): Always respect ignored files even specified (#16632)
leaysgur 6f3aa18
perf(oxfmt): make time measurement conditional (#16634)
Boshen fe00500
perf(formatter): do not write elements to the flat buffer if the layo…
Dunqing 02c78b9
perf(formatter): optimize formatting of JSX element/fragment with a s…
Dunqing b789cc8
feat(ast, parser, linter, codegen, formatter)!: rename `CommentKind::…
Dunqing 45ce007
chore(deps): update rust crate napi to v3.7.0 (#16638)
renovate[bot] 6595355
fix(linter/unicorn): fix ASI hazard in prefer-spread rule fixer (#16440)
camc314 1620618
fix(linter/prefer-at): wrap expressions in parentheses when needed fo…
camc314 486813a
docs(linter): update no-unsafe-type-assertion to reflect correct rule…
camc314 41893cc
feat(linter/plugins): `RuleTester` parser support options (#16641)
overlookmotel e92649f
feat(linter/plugins): add `languageOptions` types to `RuleTester` con…
overlookmotel b085768
chore(deps): update dependency tsdown to v0.17.2 (#16505)
renovate[bot] 42faa1a
refactor(ast): change capitalization of `CommentKind` variants (#16640)
overlookmotel 4ff0a71
chore(linter): improve auto issue readability by sorting (#16648)
r2abreu 080d245
test(linter): correct invalid syntax in no_inferrable_types test case…
camc314 fb04d6b
chore(deps): update npm packages (#15994)
renovate[bot] 14b65d3
test(linter/plugins): add conformance tests (#16650)
overlookmotel 7162d03
feat(linter): add unicorn/prefer-default-parameters rule (#16620)
re-taro 67e7110
ci(pr): label PRs as `A-linter-plugins` if they touch `apps/oxlint/co…
overlookmotel 8ca4e47
refactor(linter/plugins): refactor config merging in `RuleTester` (#1…
overlookmotel 1334377
test(linter/plugins): simplify enabling ESLint compat mode in conform…
overlookmotel d19d326
test(linter/plugins): allow filtering by rule or test case in conform…
overlookmotel 31a84de
feat(linter/plugins): `RuleTester` support `languageOptions.sourceTyp…
overlookmotel d88befd
test(lsp): activate test for filepath with brackets (#16663)
Sysix 5dda3a3
fix(linter): jsx-a11y/iframe-has-title recognizes member expressions …
Copilot fcc1058
test(linter/plugins): add tests for `sourceType` in `RuleTester` (#16…
overlookmotel bf94076
test(linter/plugins): add 1 more test case for `sourceType` in `RuleT…
overlookmotel be9f0ef
feat(linter/plugins): add `ignoreNonFatalErrors` option to `RuleTeste…
overlookmotel 427d1d3
feat(oxfmt): Enable experimental `package.json` sorting by default (#…
leaysgur 36a3f43
refactor(oxfmt): Rename `FormatFileSource` > `FormatFileStrategy` (#1…
leaysgur 50ddc83
docs(oxfmt): Improve docs for `.oxfmtrc.jsonc` config fields and add …
connorshea 02d9a82
chore(submodules): update submodule SHAs to latest commits (#16617)
Boshen 1b822ec
refactor(formatter/oxfmtrc): Update `into_format_options()` to `into_…
leaysgur 3378464
Initial plan
Copilot ab018c4
fix(formatter/sort-imports): Do not move leading comment if empty lin…
leaysgur 1b36f1b
test(lsp): move framework tests to own fixture folder (#16664)
Sysix a46660b
feat(linter/plugins): add `parserOptions.lang` option to `RuleTester`…
overlookmotel fc238ca
test(linter/plugins): shorten `RuleTester` test cases (#16689)
overlookmotel f2b1cba
feat(linter/plugins): support `parserOptions.ecmaFeatures.jsx` option…
overlookmotel 0dfb4c1
fix(linter/no-invalid-fetch-options): false positive with member expr…
Copilot 21de86e
feat(editor): adjust oxlint oxfmt config file editor supporting (#16616)
liangmiQwQ 8705661
docs(linter): Added in the missing jest rules that are compatible wit…
Afsoon d7f604b
fix(semantic): add TS1016 error code to required parameter after opti…
camc314 f43ab2f
feat(linter): add unicorn/prefer-keyboard-event-key rule (#16611)
re-taro 4fccc7f
feat(linter): add react/no-redundant-should-component-update rule (#1…
baevm 0cb5fb4
test(linter/plugins): conformance tester allow filter array (#16692)
overlookmotel a1bebed
chore(deps): update rust crate oxc-browserslist to v2.1.4 (#16696)
renovate[bot] e25ba24
chore(deps): update dependency oxlint-tsgolint to v0.8.5 (#16695)
renovate[bot] f9bf6d6
test(linter/plugins): conformance tester include test cases in report…
overlookmotel c5e96d7
feat(linter/eslint-plugin-vitest): reuse no-mocks-import jest linter …
Afsoon 185a306
docs(linter/plugins): fix typo in JSDoc comment (#16699)
overlookmotel 984cfe7
Force push clean branch
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
...s/refresh/react-refresh/generates-valid-signature-for-nested-ways-to-call-hooks/input.jsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import FancyHook from 'fancy'; | ||
|
|
||
| export default function App() { | ||
| const foo = FancyHook.property.useNestedThing(); | ||
| return <h1>{foo}</h1>; | ||
| } |
14 changes: 14 additions & 0 deletions
14
...s/refresh/react-refresh/generates-valid-signature-for-nested-ways-to-call-hooks/output.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import FancyHook from "fancy"; | ||
| import { jsx as _jsx } from "react/jsx-runtime"; | ||
| var _s = $RefreshSig$(); | ||
| export default function App() { | ||
| _s(); | ||
| const foo = FancyHook.property.useNestedThing(); | ||
| return /* @__PURE__ */ _jsx("h1", { children: foo }); | ||
| } | ||
| _s(App, "useNestedThing{foo}", false, function () { | ||
| return [FancyHook.property.useNestedThing]; | ||
| }); | ||
| _c = App; | ||
| var _c; | ||
| $RefreshReg$(_c, "App"); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.