fix(linter): Fix default behavior of the eslint/eqeqeq rule, and also the config option docs for it
#16560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #16023.
See the tests for the original rule.
We have a test in the eqeqeq.rs implementation like so:
The problem is that this test has an incorrect shape for the config object, see here:
The problem is that the code did previously handle this config array as invalid. However, because the implementation of
fromon NullType would fall back toignoreif it received bad data, it looked like it worked:Because
alwaysis marked as the default value (and is also the default value in the original ESLint rule), and so should be the default case. The test was just hitting the fallback value, so it looked like it worked, but really the fallback value was incorrect previously and did not match the docs or the ESLint behavior.This fixes that issue by correcting the fallback value, and also fixes the auto-generated config shape/docs, so it correctly represents itself as taking a tuple.
Generated docs: