-
-
Notifications
You must be signed in to change notification settings - Fork 740
docs(linter): Fix the rule config docs for eslint/no-inner-declarations rule.
#16556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
connorshea
wants to merge
18
commits into
handle-tuple-rules-better
Choose a base branch
from
inner-decls
base: handle-tuple-rules-better
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
045a51e
docs(linter): Update DefaultRuleConfig deserialization for more compl…
connorshea 073e17b
refactor(linter): Refactor the DefaultRuleConfig implementation to si…
connorshea 346f10e
Add more tests for the DefaultRuleConfig behavior.
connorshea 834dd54
Add more tests, simply code a bit hopefully.
connorshea 4df8b19
Updates for tests.
connorshea 63290ea
I'm sure this can be done better, but I've done my best trying to opt…
connorshea 6c2b76a
refactor(linter): Rewrite SortKeys config options to be a lot simpler…
connorshea 1e1aab3
fmt
connorshea 91288f3
docs(linter): Provide correct config docs for eslint/no-inner-declara…
connorshea 8d46d35
Clean the code up a bit.
connorshea 5d17357
Resolve lint warning and fix feedback.
connorshea fb8a5d3
Resolve feedback.
connorshea 6616190
Resolve lint warnings.
connorshea ae7f9d4
doctests lol
connorshea 7b72257
docs(linter): Update eslint/func-style rule to fix the config option …
connorshea bfe07b9
docs(linter): Add auto-generated config option docs for `eslint/arrow…
connorshea 3abce5e
Revert no_inner_declarations.rs back to its state on main.
connorshea 6f5894b
docs(linter): Fix the rule config docs for `eslint/no-inner-declarati…
connorshea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we can use
serde_json::from_value::<SortKeys>(value)here, so the change toDefaultRuleConfigis unnecessary?