Skip to content

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Dec 5, 2025

No description provided.

@github-actions github-actions bot added the A-editor Area - Editor and Language Server label Dec 5, 2025
Copy link
Member Author

Sysix commented Dec 5, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 5, 2025

CodSpeed Performance Report

Merging #16547 will not alter performance

Comparing 12-05-ci_benchmark_add_language_server_linter_benchmark (b8301d8) with main (8550c0f)1

Summary

✅ 42 untouched
🆕 4 new
⏩ 3 skipped2

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
🆕 Simulation language_server[react.development.js-linter] N/A 2.2 ms N/A
🆕 Simulation language_server[RadixUIAdoptionSection.jsx-linter] N/A 604.6 µs N/A
🆕 Simulation language_server[cal.com.tsx-linter] N/A 18.4 ms N/A
🆕 Simulation language_server[binder.ts-linter] N/A 4.6 ms N/A

Footnotes

  1. No successful run was found on main (4cf1353) during the generation of this report, so 8550c0f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Sysix Sysix force-pushed the 12-05-ci_benchmark_add_language_server_linter_benchmark branch from d3dacc9 to 79f9b46 Compare December 5, 2025 19:58
@camc314 camc314 self-assigned this Dec 6, 2025
@Sysix Sysix force-pushed the 12-05-ci_benchmark_add_language_server_linter_benchmark branch 8 times, most recently from 2577cbd to c2d2182 Compare December 9, 2025 19:06
@Sysix Sysix force-pushed the 12-05-ci_benchmark_add_language_server_linter_benchmark branch from c2d2182 to b8301d8 Compare December 9, 2025 19:18
@Sysix
Copy link
Member Author

Sysix commented Dec 9, 2025

This benchmark contains 14187 system calls, totalling 2.2 s of execution time. Since they cannot be consistently instrumented, those calls are not included in the measure. Please switch to the Walltime instrument to accurately measure system calls. Learn more about measurement and system calls.

https://codspeed.io/oxc-project/oxc/branches/12-05-ci_benchmark_add_language_server_linter_benchmark

@camc314 I am not sure if I should spend more time on adding a benchmark :/

@camc314
Copy link
Contributor

camc314 commented Dec 9, 2025

This benchmark contains 14187 system calls, totalling 2.2 s of execution time. Since they cannot be consistently instrumented, those calls are not included in the measure. Please switch to the Walltime instrument to accurately measure system calls. Learn more about measurement and system calls.

https://codspeed.io/oxc-project/oxc/branches/12-05-ci_benchmark_add_language_server_linter_benchmark

@camc314 I am not sure if I should spend more time on adding a benchmark :/

i agree. every time they run, we're going to get a different result 🫠

@Sysix Sysix closed this Dec 9, 2025
@Sysix Sysix deleted the 12-05-ci_benchmark_add_language_server_linter_benchmark branch December 9, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants