refactor(oxlint/lsp): prefill FixedContent.message and remove Option wrapper
#16515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-editor
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the linter's fix message handling by removing the Option wrapper from FixedContent.message and prefilling messages earlier in the processing pipeline. The change simplifies code action generation by moving the fallback message logic from fix_content_to_code_action into message_to_lsp_diagnostic, where fix messages are now populated before being converted to FixedContent.
Key changes:
- Changed
FixedContent.messagefromOption<String>toStringand prefill missing messages inmessage_to_lsp_diagnostic - Updated
message_to_lsp_diagnosticto take ownership ofMessageto enable in-place fix modification - Optimized iterator usage by changing
.iter()to.into_iter()when consuming owned collections
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| crates/oxc_language_server/src/linter/server_linter.rs | Removed alternative_message parameter from apply_fix_code_actions call |
| crates/oxc_language_server/src/linter/isolated_lint_handler.rs | Changed .iter() to .into_iter() for owned Vec<Message> collections |
| crates/oxc_language_server/src/linter/error_with_position.rs | Changed FixedContent.message to String, added message prefilling logic, and updated helper functions |
| crates/oxc_language_server/src/linter/code_actions.rs | Simplified by removing alternative message parameter and fallback logic, updated debug assertions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
graphite-app
bot
force-pushed
the
12-04-refactor_oxlint_lsp_store_option_vec_fixedcontent_for_diagnosticreport_code_action_part
branch
2 times, most recently
from
648a732 to
c82b7b0
Compare
graphite-app
bot
force-pushed
the
12-04-refactor_oxlint_lsp_prefill_fixedcontent.message_and_remove_option_wrapper
branch
from
a9c99e4 to
f005b63
Compare
Sysix
force-pushed
the
12-04-refactor_oxlint_lsp_prefill_fixedcontent.message_and_remove_option_wrapper
branch
from
f005b63 to
1372fde
Compare
Sysix
force-pushed
the
12-04-refactor_oxlint_lsp_store_option_vec_fixedcontent_for_diagnosticreport_code_action_part
branch
from
c82b7b0 to
058e234
Compare
This was referenced Dec 5, 2025
camc314
approved these changes
Dec 5, 2025
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
12-04-refactor_oxlint_lsp_store_option_vec_fixedcontent_for_diagnosticreport_code_action_part
branch
from
058e234 to
316ef44
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Dec 5, 2025
…on` wrapper (#16515) > This PR refactors the linter's fix message handling by removing the Option wrapper from FixedContent.message and prefilling messages earlier in the processing pipeline. The change simplifies code action generation by moving the fallback message logic from fix_content_to_code_action into message_to_lsp_diagnostic, where fix messages are now populated before being converted to FixedContent. The goal in the next PR is that the alternative message (from diagnostic) is no longer be stored in memory. So the title should be updated beforehand.
graphite-app
bot
force-pushed
the
12-04-refactor_oxlint_lsp_prefill_fixedcontent.message_and_remove_option_wrapper
branch
from
1372fde to
fde0e2e
Compare
Base automatically changed from
12-04-refactor_oxlint_lsp_store_option_vec_fixedcontent_for_diagnosticreport_code_action_part
to
main
December 5, 2025 13:55
…on` wrapper (#16515) > This PR refactors the linter's fix message handling by removing the Option wrapper from FixedContent.message and prefilling messages earlier in the processing pipeline. The change simplifies code action generation by moving the fallback message logic from fix_content_to_code_action into message_to_lsp_diagnostic, where fix messages are now populated before being converted to FixedContent. The goal in the next PR is that the alternative message (from diagnostic) is no longer be stored in memory. So the title should be updated beforehand.
graphite-app
bot
force-pushed
the
12-04-refactor_oxlint_lsp_prefill_fixedcontent.message_and_remove_option_wrapper
branch
from
fde0e2e to
e887d24
Compare
graphite-app
bot
deleted the
12-04-refactor_oxlint_lsp_prefill_fixedcontent.message_and_remove_option_wrapper
branch
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…on` wrapper (oxc-project#16515) > This PR refactors the linter's fix message handling by removing the Option wrapper from FixedContent.message and prefilling messages earlier in the processing pipeline. The change simplifies code action generation by moving the fallback message logic from fix_content_to_code_action into message_to_lsp_diagnostic, where fix messages are now populated before being converted to FixedContent. The goal in the next PR is that the alternative message (from diagnostic) is no longer be stored in memory. So the title should be updated beforehand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal in the next PR is that the alternative message (from diagnostic) is no longer be stored in memory. So the title should be updated beforehand.