Skip to content

test(oxlint/lsp): add CodeAction.is_preferred info to snapshot files #16513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Dec 4, 2025
Merged

test(oxlint/lsp): add CodeAction.is_preferred info to snapshot files #16513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions crates/oxc_language_server/src/linter/snapshots/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ tags: None
########### Code Actions/Commands
CodeAction:
Title: Remove the debugger statement
Is Preferred: Some(true)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -69,6 +70,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-debugger for this line
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -86,6 +88,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-debugger for this whole file
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -103,6 +106,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Remove the debugger statement
Is Preferred: Some(true)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -120,6 +124,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-debugger for this line
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -137,6 +142,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-debugger for this whole file
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -154,6 +160,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Remove the debugger statement
Is Preferred: Some(true)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -171,6 +178,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-debugger for this line
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -188,6 +196,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-debugger for this whole file
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -205,6 +214,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Remove the debugger statement
Is Preferred: Some(true)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -222,6 +232,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-debugger for this line
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -239,6 +250,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-debugger for this whole file
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand Down
3 changes: 3 additions & 0 deletions ...es/oxc_language_server/src/linter/snapshots/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ tags: None
########### Code Actions/Commands
CodeAction:
Title: Remove the debugger statement
Is Preferred: Some(true)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -36,6 +37,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-debugger for this line
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -53,6 +55,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-debugger for this whole file
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand Down
2 changes: 2 additions & 0 deletions crates/oxc_language_server/src/linter/snapshots/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ tags: None
########### Code Actions/Commands
CodeAction:
Title: Disable no-cycle for this line
Is Preferred: Some(true)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -36,6 +37,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-cycle for this whole file
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand Down
2 changes: 2 additions & 0 deletions ...ge_server/src/linter/snapshots/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ tags: None
########### Code Actions/Commands
CodeAction:
Title: Disable no-cycle for this line
Is Preferred: Some(true)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -36,6 +37,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-cycle for this whole file
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand Down
2 changes: 2 additions & 0 deletions ...napshots/[email protected]_folder__folder-dep-a.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ tags: None
########### Code Actions/Commands
CodeAction:
Title: Disable no-cycle for this line
Is Preferred: Some(true)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -43,6 +44,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-cycle for this whole file
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand Down
2 changes: 2 additions & 0 deletions ..._language_server/src/linter/snapshots/fixtures_linter_deny_no_console@hello_world.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ tags: None
########### Code Actions/Commands
CodeAction:
Title: Disable no-console for this line
Is Preferred: Some(true)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -36,6 +37,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-console for this whole file
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand Down
3 changes: 3 additions & 0 deletions .../[email protected]_another_config__not-ignored-file.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ tags: None
########### Code Actions/Commands
CodeAction:
Title: Remove the debugger statement
Is Preferred: Some(true)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -40,6 +41,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-debugger for this line
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -57,6 +59,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-debugger for this whole file
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand Down
4 changes: 4 additions & 0 deletions crates/oxc_language_server/src/linter/snapshots/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ tags: None
########### Code Actions/Commands
CodeAction:
Title: Disable no-extra-boolean-cast for this line
Is Preferred: Some(true)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -61,6 +62,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-extra-boolean-cast for this whole file
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -78,6 +80,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-non-null-asserted-optional-chain for this line
Is Preferred: Some(true)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -95,6 +98,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-non-null-asserted-optional-chain for this whole file
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand Down
3 changes: 3 additions & 0 deletions crates/oxc_language_server/src/linter/snapshots/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ tags: None
########### Code Actions/Commands
CodeAction:
Title: Remove the debugger statement
Is Preferred: Some(true)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -36,6 +37,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-debugger for this line
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -53,6 +55,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-debugger for this whole file
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand Down
4 changes: 4 additions & 0 deletions ...uage_server/src/linter/snapshots/fixtures_linter_multiple_suggestions@forward_ref.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ tags: None
########### Code Actions/Commands
CodeAction:
Title: remove `forwardRef` wrapper
Is Preferred: Some(true)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -36,6 +37,7 @@ TextEdit: TextEdit {

CodeAction:
Title: add `ref` parameter
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -53,6 +55,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable forward-ref-uses-ref for this line
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -70,6 +73,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable forward-ref-uses-ref for this whole file
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand Down
5 changes: 5 additions & 0 deletions crates/oxc_language_server/src/linter/snapshots/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ tags: None
########### Code Actions/Commands
CodeAction:
Title: Disable no-control-regex for this line
Is Preferred: Some(true)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -47,6 +48,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-control-regex for this whole file
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -64,6 +66,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Replace `\/` with `/`.
Is Preferred: Some(true)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -81,6 +84,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-useless-escape for this line
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -98,6 +102,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-useless-escape for this whole file
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand Down
7 changes: 7 additions & 0 deletions crates/oxc_language_server/src/linter/snapshots/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ tags: None
########### Code Actions/Commands
CodeAction:
Title: Disable no-unassigned-vars for this line
Is Preferred: Some(true)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -58,6 +59,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-unassigned-vars for this whole file
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -75,6 +77,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-unassigned-vars for this line
Is Preferred: Some(true)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -92,6 +95,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-unassigned-vars for this whole file
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -109,6 +113,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Remove the debugger statement
Is Preferred: Some(true)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -126,6 +131,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-debugger for this line
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand All @@ -143,6 +149,7 @@ TextEdit: TextEdit {

CodeAction:
Title: Disable no-debugger for this whole file
Is Preferred: Some(false)
TextEdit: TextEdit {
range: Range {
start: Position {
Expand Down
Loading
Loading