-
-
Notifications
You must be signed in to change notification settings - Fork 83
Add flake to cross-mingw example #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add flake to cross-mingw example #219
Conversation
|
Can we also add CI tests for this, like the (cross-aarch64, flake) tuple? Previously I found MinGW tests on unstable sometimes does not work. Hope a locked flake test can mitigate it. rust-overlay/.github/workflows/ci.yaml Lines 158 to 164 in caa2fef
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you would like this flake to use
mkRustBintoo, and if you're extra nice, attempt to explain why one should use it 😄
mkRustBin is a non-overlay interface. Overlay interface is only efficient when there is only a single import nixpkgs with all overlays applied at once, this may not be possible when you have a very complex flake dependency graph and dependency flakes are using their own nixpkgs, causing overlays to import nixpkgs multiple times with the cost of eval time.
In this example there is obviously only one import nixpkgs, so I don't have a strong opinion on it. You can keep import nixpkgs for now.
Thank you for the explanation! I get it now. Then I would like to leave it as-is. |
Sure, although I don't have any experience with GitHub workflows. Would something like this already do the job? include:
- example: cross-aarch64
kind: flake
+ - example: cross-mingw
+ kind: flakeIf it's more complex, it might be faster for someone who has worked with GitHub workflows before to do it in a separate PR instead. |
On another note: What do you mean by "locked" flake test? I did not push the |
Adds a flake to the cross-mingw example.
Without
mkRustBinfor now, as I was not able to understand what benefit(s) it brings me, plus I find the syntax more difficult to read/understand.Let me know if you would like this flake to use
mkRustBintoo, and if you're extra nice, attempt to explain why one should use it 😄But even then, it might be nice to have (at least) one flake example that shows how it could look without
mkRustBin.