-
Notifications
You must be signed in to change notification settings - Fork 4
Pin python version to 3.12 #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @1pav, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a compatibility issue where the project's dependency management tool ( Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request pins the Python version to 3.12 by adding a .python-version file, which is a good measure to ensure development environment consistency and resolve the noted incompatibility with Python 3.14. My main feedback is that the requires-python setting in pyproject.toml should also be updated to reflect this stricter version requirement. This will ensure the package's metadata is accurate and prevent installation on unsupported Python versions.
owtaylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update the .python-version in pyproject.toml to 3.12 but leave it as a >=
owtaylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
According to pyproject.toml the minimum required python version for the project is 3.6:
however,
uvwill pick the first python version that is compatible with the requirement. On my environment (F43), that is python3.14, which seems to be incompatible with some code, e.g. when running tests:The above will work fine with python3.12.
It is usually recommended to pin python version via .python-version. Apparently we are using 3.12 also in CI, so that's what I set it to.