Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: property Discovers() in client.go #8951

Closed

Conversation

jnweiger
Copy link
Contributor

Storing json Decode() results in the client c object does not seem right. It probably silently ignores everything.

There is an unused var cap Capabilities directly above, that is returned uninitialized directly below. I assume it was meant to use this variable.

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Storing json Decode() results in the client c object does not seem right. It probably silently ignores everything.

There is an unused var cap Capabilities directly above, that is returned uninitialized directly below. 
I assume it was meant to use this variable.
@jnweiger jnweiger requested a review from aduffeck April 24, 2024 13:09
Copy link

update-docs bot commented Apr 24, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@DeepDiver1975
Copy link
Member

this needs to be fixed upstream in the reva repo - branch edge ...

once merged there, backported (?) and released it can be pulled into the ocis repo.
yes it's a mess ...

@jnweiger
Copy link
Contributor Author

Following up there: cs3org/reva#4662

@DeepDiver1975
Copy link
Member

let's close this in here for now.

@mmattel mmattel deleted the jnweiger-discover-properties-into-cap-variable branch February 14, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants