Skip to content

refactor: ocs sharing and space members refactor - #5002

Open
joragua wants to merge 8 commits into
masterfrom
technical/ocs_sharing_and_members_refactor
Open

refactor: ocs sharing and space members refactor#5002
joragua wants to merge 8 commits into
masterfrom
technical/ocs_sharing_and_members_refactor

Conversation

@joragua

@joragua joragua commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Related Issues

App: #4949

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

joragua added 4 commits October 1, 2026 13:00
@joragua
refactor: improve filter for space members
4701a07 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
refactor: set up roles adapter for space members in onViewCreated method
c77761e 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
feat: delay member search request until typing stops
791a9bd 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
refactor: extract shared fragment logic to extensions to avoid duplic…
bcaefaa 
…ated code

Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua joragua self-assigned this Oct 1, 2026
@joragua joragua linked an issue Oct 1, 2026 that may be closed by this pull request
[TECHNICAL] OCS sharing and space members refactor #4949
Open
13 of 15 tasks
@joragua joragua changed the title technical: ocs sharing and space members refactor refactor: ocs sharing and space members refactor Oct 1, 2026
@joragua
refactor: use neutral names for UI shared between shares and space me…
80fc724 
…mbers

Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
joragua force-pushed the technical/ocs_sharing_and_members_refactor branch from 90249b4 to e40d9f5 Compare October 6, 2026 15:58
@joragua
joragua marked this pull request as ready for review October 7, 2026 07:36
@joragua
joragua requested a review from a team as a code owner October 7, 2026 07:36
jesmrec
jesmrec requested changes Oct 7, 2026
View reviewed changes
Comment thread ...dApp/src/androidTest/java/com/owncloud/android/sharing/shares/ui/OcsShareFileFragmentTest.kt Outdated
Comment thread ...dApp/src/main/java/com/owncloud/android/presentation/spaces/members/SpaceMembersViewModel.kt
joragua added 3 commits October 7, 2026 13:42
@joragua
refactor: add Ocs prefix to legacy sharing classes across all layers
7665f48 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
chore: add calens file
d72ae14 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
fix: cancel pending search job when clearing member search
53480e5 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
joragua force-pushed the technical/ocs_sharing_and_members_refactor branch from e2a4975 to 53480e5 Compare October 7, 2026 12:03
@joragua
joragua requested a review from jesmrec October 7, 2026 12:13
@jesmrec

jesmrec commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

CR done, let's move to QA

@jesmrec

jesmrec commented Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

QA checks

  • Space management
    • Add member to space
    • Edit member to space
    • Remove member to space
    • Accessibilty
  • Sharing NG
    • Create share
    • Edit share
    • Remove share
    • Accessibility
  • Sharing OCS
    • Create share
    • Edit share
    • Remove share
    • Accessibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jesmrec jesmrec jesmrec approved these changes

Assignees

@joragua joragua

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[TECHNICAL] OCS sharing and space members refactor

2 participants

@joragua @jesmrec