Skip to content

feat: adapt remove message in dialog to ocis - #5001

Merged
jesmrec merged 2 commits into
masterfrom
feature/remove_dialog_alert_message
Oct 1, 2026
Merged

jesmrec merged 2 commits into
masterfrom
feature/remove_dialog_alert_message

Conversation

@jesmrec

@jesmrec jesmrec commented Oct 1, 2026

Copy link
Copy Markdown
Member

Related Issues

App:

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@jesmrec jesmrec self-assigned this Oct 1, 2026
@jesmrec jesmrec added this to the 4.9 - Current milestone Oct 1, 2026
@jesmrec
jesmrec marked this pull request as ready for review October 1, 2026 11:08
@jesmrec
jesmrec requested a review from a team as a code owner October 1, 2026 11:08
@jesmrec jesmrec closed this Oct 1, 2026
@jesmrec jesmrec reopened this Oct 1, 2026
Signed-off-by: Jesus Recio <jrecio@izertis.com>
Signed-off-by: Jesus Recio <jrecio@izertis.com>
@jesmrec
jesmrec force-pushed the feature/remove_dialog_alert_message branch from af4c9df to f3204de Compare October 1, 2026 11:18

@joragua joragua left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@jesmrec

jesmrec commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

QA checks

  • Dialog in oCIS in both orientations: Remove share
  • Dialog in oC Classic in both orientations: Remove private share

@jesmrec

jesmrec commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

Approved

@jesmrec
jesmrec merged commit 2ea8935 into master Oct 1, 2026
11 checks passed
@jesmrec
jesmrec deleted the feature/remove_dialog_alert_message branch October 1, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants