Skip to content

feat: set custom toolbar title when editing or creating a share #5000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joragua merged 2 commits into from
Oct 1, 2026
Merged

feat: set custom toolbar title when editing or creating a share #5000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c26178
feat: set custom toolbar title when editing or creating a share
joragua Oct 1, 2026
200411a
chore: add calens file
joragua Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/unreleased/4952
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ It will be only visible for users with proper permissions.
https://github.com/owncloud/android/issues/4875
https://github.com/owncloud/android/issues/4917
https://github.com/owncloud/android/pull/4952
https://github.com/owncloud/android/pull/5000
1 change: 1 addition & 0 deletions changelog/unreleased/4978
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ It will be only visible for users with proper permissions.

https://github.com/owncloud/android/issues/4937
https://github.com/owncloud/android/pull/4978
https://github.com/owncloud/android/pull/5000
2 changes: 2 additions & 0 deletions owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/AddGraphShareFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ class AddGraphShareFragment : Fragment(), SearchMembersAdapter.SearchMembersAdap
editMode = requireArguments().getBoolean(ARG_EDIT_MODE, false)
roles = requireArguments().getParcelableArrayList(ARG_ROLES) ?: emptyList()

requireActivity().title = getString(if (editMode) R.string.share_edit else R.string.share_add)

searchMembersAdapter = SearchMembersAdapter(this)
recyclerView = binding.membersRecyclerView
recyclerView.apply {
Expand Down
1 change: 1 addition & 0 deletions owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/GraphShareFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ class GraphShareFragment : Fragment(), GraphSharesAdapter.GraphSharesAdapterList

override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
super.onViewCreated(view, savedInstanceState)
requireActivity().title = getString(R.string.share_dialog_title)
binding.membersTitle.text = getString(R.string.share_with_people_title)

graphSharesAdapter = GraphSharesAdapter(this)
Expand Down
2 changes: 2 additions & 0 deletions owncloudApp/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,11 +494,13 @@
<string name="share_with_user_section_title">Users and Groups</string>
<string name="share_no_users">No data shared with users yet</string>
<string name="share_sync_failed">Shares could not be refreshed</string>
<string name="share_add">Create share</string>
<string name="share_add_correctly">Share created correctly</string>
<string name="share_add_failed">Share could not be created</string>
<string name="share_add_conflict_error">Is already shared with this user/group</string>
<string name="share_remove_correctly">Share removed correctly</string>
<string name="share_remove_failed">Share could not be removed</string>
<string name="share_edit">Edit share</string>
<string name="share_edit_correctly">Share edited correctly</string>
<string name="share_edit_failed">Share could not be edited</string>
<string name="share_via_link_section_title">Public links</string>
Expand Down
Loading