Repository navigation
build(deps): bump com.android.tools.build:gradle from 8.7.2 to 9.2.1 #4865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Change: Bump AGP from 8.7.2 to 9.2.1 | ||
|
|
||
| Android Gradle Plugin (AGP) has been updated from version 8.7.2 to 9.2.1, along | ||
| with other dependencies required to build the app with this new version. | ||
|
|
||
| https://github.com/owncloud/android/pull/4865 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,4 @@ | ||
| android.defaults.buildfeatures.buildconfig=true | ||
| android.enableJetifier=true | ||
| android.nonFinalResIds=false | ||
| android.nonTransitiveRClass=false | ||
| android.useAndroidX=true | ||
| org.gradle.jvmargs=-Xmx1536M |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.9-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.4.1-bin.zip | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,9 @@ | |
| * @author David A. Velasco | ||
| * @author Christian Schabesberger | ||
| * @author David González Verdugo | ||
| * Copyright (C) 2020 ownCloud GmbH. | ||
| * @author Jorge Aguado Recio | ||
| * | ||
| * Copyright (C) 2026 ownCloud GmbH. | ||
| * <p> | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License version 2, | ||
|
|
@@ -292,32 +294,28 @@ public void setEnabled(boolean enabled) { | |
| public void onClick(View v) { | ||
| int pos; | ||
| boolean playing = mPlayer.isPlaying(); | ||
| switch (v.getId()) { | ||
|
|
||
| case R.id.playBtn: | ||
| doPauseResume(); | ||
| break; | ||
|
|
||
| case R.id.rewindBtn: | ||
| pos = mPlayer.getCurrentPosition(); | ||
| pos -= 5000; | ||
| mPlayer.seekTo(pos); | ||
| if (!playing) { | ||
| mPlayer.pause(); // necessary in some 2.3.x devices | ||
| } | ||
| setProgress(); | ||
| break; | ||
|
|
||
| case R.id.forwardBtn: | ||
| pos = mPlayer.getCurrentPosition(); | ||
| pos += 15000; | ||
| mPlayer.seekTo(pos); | ||
| if (!playing) { | ||
| mPlayer.pause(); // necessary in some 2.3.x devices | ||
| } | ||
| setProgress(); | ||
| break; | ||
|
|
||
| int id = v.getId(); | ||
|
|
||
| // Using an if / else if / else block because Java switch statements | ||
| // with resource ID comparisons are no longer supported in AGP 9 | ||
| if (id == R.id.playBtn) { | ||
| doPauseResume(); | ||
| } else if (id == R.id.rewindBtn) { | ||
| pos = mPlayer.getCurrentPosition(); | ||
| pos -= 5000; | ||
| mPlayer.seekTo(pos); | ||
| if (!playing) { | ||
| mPlayer.pause(); // necessary in some 2.3.x devices | ||
| } | ||
| setProgress(); | ||
| } else if (id == R.id.forwardBtn) { | ||
| pos = mPlayer.getCurrentPosition(); | ||
| pos += 15000; | ||
| mPlayer.seekTo(pos); | ||
| if (!playing) { | ||
| mPlayer.pause(); // necessary in some 2.3.x devices | ||
| } | ||
| setProgress(); | ||
|
Comment on lines
+297
to
+318
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IMO, this change deserves a comment related with the switches in Java for resource IDs in AGP 9
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added ✅
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💯 |
||
| } | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That new directive has been only added to
owncloudAppmodule. Should it be added to the other modules?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not necessary since
buildConfigonly applies for the main module (ownCloudApp)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍