Repository navigation
[BUG] Bad grid mode after changing orientation #4884
Description
Activity
Confirmed. Root cause: the grid column count is never recomputed on rotation.
spanCountfor grid mode is set fromColumnQuantity.calculateNoOfColumns()only at init (MainFileListFragment.kt:394) and on the view-type toggle (MainFileListFragment.kt:1006).onConfigurationChanged(MainFileListFragment.kt:332) callsupdateConfigDependentSizes()(:337), which resizes only the space-header card and empty-state icon — it does not touchlayoutManager.spanCount.calculateNoOfColumns()is width-dependent (ColumnQuantity.kt:45, usesdisplayMetrics.widthPixels), so the count computed in landscape (wide → more columns) stays applied after rotating to portrait (narrow), overlapping items. Matches the repro (set grid in landscape, rotate to portrait).
Fix outline: recompute and reapply the grid span in
updateConfigDependentSizes()when the current view type is grid, e.g.if (viewType == ViewType.VIEW_TYPE_GRID) layoutManager.spanCount = ColumnQuantity(requireContext(), R.layout.grid_item).calculateNoOfColumns(), then re-lay-out.Same orientation/config-change area as #4803.
Aside:
calculateNoOfColumns()atColumnQuantity.kt:48computesnumberOfColumns.minus(1)but discards the result (not reassigned) — the intended column reduction is a no-op. Worth fixing alongside.🤖 Generated with Claude Code
- linked a pull request that will close this issuefix: recalculate grid span count after rotation #4935
on Jul 21, 2026
Steps to reproduce
Actual behaviour
Icons and thumbnails are overlapped like:
Expected behaviour
Correctly displayed like:
Xiaomi Redmi Note 13
Android 15