Fix/tbb cmake macro #194
Merged
Fix/tbb cmake macro #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a system where several nvcc toolkit are installed, this path is often an alias to the latest installed toolkit; hence when trying to build with an older version off nvcc you end up in a situation where the old nvcc compiler is using new header; this situation may lead to error at link time (undefined symbols). See issue owl-project#191 for discussion.
Currently macro owl/cmake/FindTBB.cmake is slightly out-dated because it tries to find header task_scheduler_int.h which has been remove from TBB in version 2021.1 So currenlty, the macro fails to find recent TBB (actually OneTBB). This commit fix this problem by first trying to detect OneTBB using find_package in CONFIG mode, then use the old macro adapted to older TBB version.
|
seems to work just find in all optix versions i tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix issue #193