fix(iis): IPv6 Handling in ModSecurity IIS Module #3443
+48
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tionality Refactor the `GetIpAddr` function to use `GetNameInfo` for IP address retrieval, enhancing IPv6 compatibility. Optimize the `CopySockAddr` function to correctly handle IPv4 and IPv6 addresses and port information. (Implementation based on mujiansu's work in issue owasp-modsecurity#1988)
|
|
Hi @A13501350, thanks for this PR. Unfortunately SonarCloud found some errors. I reviewed them and seems like those are not critical and easy to fix them. Could you take a look at them? See the SonarCloud check line or this link. |
|
Yeah. The fixes themselves are straightforward, but implementing them would introduce changes that differ from the existing code in terms of features and style. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
WSAAddressToStringand manual string parsing approach with theGetNameInfofunction for IP address retrieval.CopySockAddrfunction.why
The original implementation incorrectly assumed all addresses were IPv4, causing failures when processing IPv6 connections.
references