feat: add specific code path for AWX #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ansible bastion wrapper default lookup to get bastion vars, is to run "ansible-inventory --list" A downside of this way of doing, is that the whole inventory is going to be evaluated, and if we are using some custom vars plugins, there are executed to. It can end up being very time consuming. When using AWX, the whole inventory is available in the AWX Execution Environment as a file. So it is much easier and faster to get the host associated to the requested ip (the ip sent by Ansible to the ssh wrapper). Then, we can look for the bastion vars in the host vars, and if not found, execute "ansible-inventory --host" on the specific host, instead of the whole inventory.
wilfriedroset
pushed a commit
that referenced
this pull request
Apr 26, 2024
* feat: add specific code path for AWX The ansible bastion wrapper default lookup to get bastion vars, is to run "ansible-inventory --list" A downside of this way of doing, is that the whole inventory is going to be evaluated, and if we are using some custom vars plugins, there are executed to. It can end up being very time consuming. When using AWX, the whole inventory is available in the AWX Execution Environment as a file. So it is much easier and faster to get the host associated to the requested ip (the ip sent by Ansible to the ssh wrapper). Then, we can look for the bastion vars in the host vars, and if not found, execute "ansible-inventory --host" on the specific host, instead of the whole inventory. * remove isort, as it conflicts with black to maange import with style --------- Co-authored-by: Damien Cavagnini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ansible bastion wrapper default lookup to get bastion vars, is to run "ansible-inventory --list" A downside of this way of doing, is that the whole inventory is going to be evaluated, and if we are using some custom vars plugins, there are executed to. It can end up being very time consuming.
When using AWX, the whole inventory is available in the AWX Execution Environment as a file. So it is much easier and faster to get the host associated to the requested ip (the ip sent by Ansible to the ssh wrapper). Then, we can look for the bastion vars in the host vars, and if not found, execute "ansible-inventory --host" on the specific host, instead of the whole inventory.