feat(instances) - distance backup lot 1 light #19751
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aTurmo
requested review from
Tsiorifamonjena,
aboungnaseng-ovhcloud,
anooparveti,
fredericvilcot,
helabenkhalfallah,
lionel95200x,
lolottetheclash,
manoncarbonnel and
ppprevost
github-actions
bot
added
translation required
dependencies
|
| Name | Status | Previous | Current |
|---|---|---|---|
react-hook-form |
7.56.1 | 7.65.0 |
aTurmo
force-pushed
the
feat/TAPC-5216_distant_backup_lot_1_light
branch
from
c122414 to
daf2414
Compare
…tatus ref: #TAPC-3055 Signed-off-by: Adrien Turmo <[email protected]>
…kform + zod) ref: #TAPC-3053 Signed-off-by: Adrien Turmo <[email protected]>
… input validation for zod ref: #TAPC-3053 Signed-off-by: Adrien Turmo <[email protected]>
…new custom form fields ref: #TAPC-3053 Signed-off-by: Adrien Turmo <[email protected]>
ref: #TAPC-3053 Signed-off-by: Adrien Turmo <[email protected]>
…odal to include distant backup ref: #TAPC-3053 Signed-off-by: Adrien Turmo <[email protected]>
aTurmo
force-pushed
the
feat/TAPC-5216_distant_backup_lot_1_light
branch
from
daf2414 to
a6ad1ee
Compare
packages/manager/apps/pci-instances/src/data/hooks/instance/action/useInstanceBackupPrice.tsx
Show resolved
Hide resolved
…pAvailable ref: #TAPC-3053 Signed-off-by: Adrien Turmo <[email protected]>
| <Text>{label}</Text> | ||
|
|
||
| {badges && badges.length && ( | ||
| <span className={'ml-4 flex flex-row gap-2 flex-wrap'}> |
There was a problem hiding this comment.
Suggested change
| <span className={'ml-4 flex flex-row gap-2 flex-wrap'}> | |
| <span className='ml-4 flex flex-row gap-2 flex-wrap'> |
| </div> | ||
| <Wrapper> | ||
| <div id={id} className="px-8 pt-6 pb-10"> | ||
| <div id={id}> |
There was a problem hiding this comment.
chore: two <div> with the same id will generate problems in the DOM.
suggestion: To avoid div soup you can use a <section>tag since it contains a heading inside.
ppprevost
reviewed
Oct 16, 2025
| continents, | ||
| }: { | ||
| projectId: string; | ||
| continents: ReturnType<typeof useInstanceBackupPrice>['distantContinents']; |
There was a problem hiding this comment.
suggestion: do not couple this type from a hook from a very distant folder and considerate to have a type for this
lolottetheclash
previously approved these changes
Oct 17, 2025
… distantContinents type ref: #TAPC-3053 Signed-off-by: Adrien Turmo <[email protected]>
ppprevost
approved these changes
Oct 17, 2025
lolottetheclash
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #TAPC-3053, #TAPC-3055