Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(billing): add forgotten services helper from dedicated #14995

Merged
merged 2 commits into from
Jan 23, 2025
Merged

fix(billing): add forgotten services helper from dedicated #14995

merged 2 commits into from
Jan 23, 2025

Conversation

MaximeBajeux
Copy link
Contributor

@MaximeBajeux MaximeBajeux commented Jan 17, 2025 •
edited
Loading

Question Answer
Branch? master
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #...
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

we forgot to migrate a service located in a component directory

Related

@MaximeBajeux MaximeBajeux requested a review from a team as a code owner January 17, 2025 14:20
@github-actions github-actions bot added the bug Something isn't working label Jan 17, 2025
fix(billing): clean billing code from dedicated
385004a 
ref: MANAGER-16767

Signed-off-by: Maxime Bajeux <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
75.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@MaximeBajeux MaximeBajeux changed the base branch from master to release/incidents-gcj January 23, 2025 07:45
@MaximeBajeux MaximeBajeux merged commit a2c5f54 into release/incidents-gcj Jan 23, 2025
17 of 18 checks passed
@MaximeBajeux MaximeBajeux deleted the fix/billing-payg branch January 23, 2025 10:02
@MaximeBajeux MaximeBajeux mentioned this pull request Jan 23, 2025
Merged
4 tasks
MaximeBajeux added a commit that referenced this pull request Jan 23, 2025
@MaximeBajeux
fix(billing): add forgotten services helper from dedicated (#14995)
ade051f 
ref: MANAGER-16767
Signed-off-by: Maxime Bajeux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesLarique JacquesLarique JacquesLarique approved these changes

@aottr aottr aottr approved these changes

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss was automatically assigned from ovh/team-manager-dev-angularjs

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaximeBajeux @aottr @JacquesLarique