Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci : delete playwright and e2e tests #14981

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

ci : delete playwright and e2e tests #14981

wants to merge 1 commit into from
+1 −9

Conversation

aboungnaseng-ovhcloud
Copy link
Contributor

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud commented Jan 17, 2025 •
edited
Loading

Question Answer
Branch? develop
Bug fix? no
New feature? no
Breaking change? no
Tickets 14558
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Delete playwright and e2e command in github action

Related

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud requested review from a team as code owners January 17, 2025 10:09
@github-actions github-actions bot added continuous-integration Changes to our CI configuration files and scripts dependencies Pull requests that update a dependency file universe-public-cloud feature New feature labels Jan 17, 2025
@aboungnaseng-ovhcloud aboungnaseng-ovhcloud force-pushed the feat/MANAGER-14558 branch 2 times, most recently from 1086d16 to ebfccc6 Compare January 17, 2025 10:14
@github-actions github-actions bot removed dependencies Pull requests that update a dependency file universe-public-cloud labels Jan 17, 2025
@aboungnaseng-ovhcloud
ci: delete playwright install and e2e tests command
1691a60 
ref: MANAGER-14558

Signed-off-by: Alex Boungnaseng <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

anooparveti
anooparveti requested changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@anooparveti anooparveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should all also remove all the e2e tests and the playwright helpers that exists on the repo.

@aboungnaseng-ovhcloud
Copy link
Contributor Author

aboungnaseng-ovhcloud commented Jan 17, 2025 •
edited
Loading

We should all also remove all the e2e tests and the playwright helpers that exists on the repo.

you're right but we had to wait the clean of the others features teams cause they use playwright helpers in their code.

In the last step we can clean the playwright helpers folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristanwagner tristanwagner tristanwagner approved these changes

@chipp972 chipp972 chipp972 approved these changes

@tibs245 tibs245 tibs245 approved these changes

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
continuous-integration Changes to our CI configuration files and scripts feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aboungnaseng-ovhcloud @tibs245 @chipp972 @tristanwagner @anooparveti