Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(key-management-service): add KMIP RSA endpoint on dashboard #14971

Merged
merged 1 commit into from
Jan 28, 2025
Merged

feat(key-management-service): add KMIP RSA endpoint on dashboard #14971

merged 1 commit into from
Jan 28, 2025

Conversation

darsene
Copy link
Contributor

@darsene darsene commented Jan 16, 2025 •
edited
Loading

ref: MANAGER-16278

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-16278
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

old PR : #14685

@darsene darsene requested review from a team as code owners January 16, 2025 17:44
@darsene darsene requested review from chipp972, ghyenne, sidlynx, kqesar, qpavy and anooparveti and removed request for a team January 16, 2025 17:44
@darsene darsene force-pushed the feat/MANAGER-16278-bis branch from 2af541b to f3dab15 Compare January 16, 2025 17:49
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jan 20, 2025
@rjamet-ovh rjamet-ovh force-pushed the feat/kms-ods18 branch 3 times, most recently from 7cce9ed to 632e52d Compare January 24, 2025 09:45
@rjamet-ovh rjamet-ovh force-pushed the feat/kms-ods18 branch 3 times, most recently from fba6372 to 701dae6 Compare January 28, 2025 15:39
@rjamet-ovh rjamet-ovh mentioned this pull request Jan 28, 2025
Merged
3 tasks
Base automatically changed from feat/kms-ods18 to release/kms-ods18 January 28, 2025 16:09
@darsene darsene force-pushed the feat/MANAGER-16278-bis branch from f3dab15 to af7ec0e Compare January 28, 2025 16:22
@github-actions github-actions bot added translation required and removed has conflicts Has conflicts to resolve before merging labels Jan 28, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rjamet-ovh rjamet-ovh merged commit 2471a29 into release/kms-ods18 Jan 28, 2025
15 checks passed
@rjamet-ovh rjamet-ovh deleted the feat/MANAGER-16278-bis branch January 28, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjamet-ovh rjamet-ovh rjamet-ovh approved these changes

@pauldkn pauldkn pauldkn approved these changes

@chipp972 chipp972 Awaiting requested review from chipp972 chipp972 was automatically assigned from ovh/team-manager-dev-reactjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne was automatically assigned from ovh/team-manager-dev-reactjs

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy was automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
enabler feature New feature quality check: ok translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darsene @pauldkn @rjamet-ovh