Port csrc extension to PyTorch stable ABI#308
Open
tiran wants to merge 1 commit into
Open
Conversation
Replace pybind11 + torch/extension.h bindings with PyTorch's stable ABI (STABLE_TORCH_LIBRARY, torch::stable::Tensor, torch::stable::Device). This decouples the extension from specific PyTorch C++ ABI versions. - Register ops via STABLE_TORCH_LIBRARY + TORCH_BOX instead of PYBIND11_MODULE - Replace torch::Tensor/Device/Dtype with stable::Tensor/Device and headeronly::ScalarType throughout - Replace torch::from_blob with torch::stable::from_blob - Add kvcached/vmm_ops.py wrapper that loads _vmm_ops_lib and re-exports ops via torch.ops.kvcached.*, preserving existing import API - Remove torch_python from linked libraries, rename extension to _vmm_ops_lib - Remove dead free_ftensor_() and torch_utils.ipp Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Christian Heimes <cheimes@redhat.com>
Author
|
I have addressed the code format issues with |
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace pybind11 + torch/extension.h bindings with PyTorch's stable ABI (STABLE_TORCH_LIBRARY, torch::stable::Tensor, torch::stable::Device). This decouples the extension from specific PyTorch C++ ABI versions.
Fixes: #306