Resolve splash version from installed package metadata - #4
Merged
Conversation
The splash screen's VERSION constant was a hardcoded string, patched by CI only while building the .deb. Pip and source installs therefore kept showing 2026.04.16 long after newer releases shipped. VERSION is now computed at startup from importlib.metadata, with a _BUNDLED_VERSION fallback preserved for environments where the package is not registered (editable/dev runs). CalVer zero-padding is reapplied so the splash reads 2026.04.18 rather than the PEP 440 normalized 2026.4.18. CI now patches _BUNDLED_VERSION instead of VERSION. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
importlib.metadata.version("aisisstant")at startup, so pip/source installs stop showing the stale hardcoded constant.2026.04.18→2026.4.18; we want the padded form on the UI)._BUNDLED_VERSIONas a fallback; CI now patches that name instead ofVERSION.Test plan
pytestsuite passes (167/167)_BUNDLED_VERSIONcorrectlyaisisstant-setup --wizardon the installed pip version and confirm splash showsVERSION 2026.04.18.1(current latest), not2026.04.16