Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an assert referencing checkLightId, which seems not to exist anywhere #1263

Merged

Conversation

daleglass
Copy link
Contributor

This one is confusing me greatly.

It's a line from 8 years ago, and apparently this hasn't been blowing up for anyone else?

/home/dale/git/overte/overte/libraries/render-utils/src/LightStage.cpp: In member function ‘void LightStage::updateLightArrayBuffer(render::Stage::Index)’:
/home/dale/git/overte/overte/libraries/render-utils/src/LightStage.cpp:392:12: error: ‘checkLightId’ was not declared in this scope
  392 |     assert(checkLightId(lightId));
      |            ^~~~~~~~~~~~

There appear to be no references to this function in the source.

Copy link
Member

@HifiExperiments HifiExperiments left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I accidentally removed this in #1177 but only compiled in release mode, sorry

@daleglass
Copy link
Contributor Author

that’s fun…is it being compiled out?

No, the function just seems to be completely missing from the source

@daleglass daleglass merged commit 8f1c08a into overte-org:master Dec 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants