Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ArmoredChat timestamps to use real timestamps #1241

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

Armored-Dragon
Copy link
Member

This changes the time saving method to just timestamps provided by Date.now() instead of saving formatted strings. This will allow for easily changing the displayed timestamp to match proper locales in the future.

This also prevents saving some unneeded data in the interface.json file.

@Armored-Dragon Armored-Dragon added enhancement New feature or request needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested labels Nov 17, 2024
@Armored-Dragon Armored-Dragon self-assigned this Nov 17, 2024
Copy link
Member

@ksuprynowicz ksuprynowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Al looks good :)

@ksuprynowicz ksuprynowicz added CR approved This pull request has been successfully code reviewed QA approved This pull request has been successfully tested and removed needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested labels Nov 28, 2024
@ksuprynowicz
Copy link
Member

I tested it, all works well

@ksuprynowicz ksuprynowicz merged commit a59047d into overte-org:master Nov 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR approved This pull request has been successfully code reviewed enhancement New feature or request QA approved This pull request has been successfully tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants