Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Unified UI ] Settings UI (updated) #1240

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

Armored-Dragon
Copy link
Member

Continuation of #1125.

@Armored-Dragon Armored-Dragon added enhancement New feature or request work in progress Do not merge yet labels Nov 16, 2024
@Armored-Dragon Armored-Dragon self-assigned this Nov 16, 2024
@Armored-Dragon Armored-Dragon mentioned this pull request Nov 16, 2024
7 tasks
@Armored-Dragon
Copy link
Member Author

This is getting closer to a final product. There are a few design irritations I want to poke at to see if I can come up with a more functional result. Mainly that the boolean toggles look too alike the combobox elements. I would like these to be a bit more visually distinct at a glance, while also still looking similar to everything. I feel the balance is not quite ready yet.

That's ignoring the obvious missing changes to the number input.

image

@Armored-Dragon
Copy link
Member Author

Here are the custom int inputs as well as the custom slider elements.
image

@Armored-Dragon Armored-Dragon marked this pull request as ready for review November 20, 2024 07:47
@Armored-Dragon
Copy link
Member Author

Armored-Dragon commented Nov 20, 2024

I am going to mark this as ready to review so this application does not get too far behind the master branch. Each settings category will be their own pull request.
This pull requests is the initial settings application, as well as the 'Graphics' options.

@Armored-Dragon Armored-Dragon added needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested and removed work in progress Do not merge yet labels Nov 20, 2024
@ksuprynowicz
Copy link
Member

It looks really clean :)

@dallytaur
Copy link

was talking in game about the stylist input device and have suggestion if your pen pas the local yx plane of the tablet you should lock the pen so it can't pass screen and combine it with a hapic buzz to say you hit something

this allow the user to ground the feeling of tablet to feel more real

if a user desires to clip though the table the collision box behine the xy plane if the controller pushes thought the box then the pen snaps back to users hand

@Armored-Dragon Armored-Dragon marked this pull request as draft December 21, 2024 09:41
@ksuprynowicz
Copy link
Member

During the UI redesign we need to make sure that all the UI text is selectable/hightlightable, so it can be read by text to speech accessibility programs. (Thanks to Michelle for this tip!)

Added icon to Settings submenu listing.
@Armored-Dragon Armored-Dragon marked this pull request as ready for review January 4, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants