Fix access-after-delete during entity script engine cleanup #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksuprynowicz
added
bug
|
Big thanks to Alezia for providing domain content files that made it possible to reproduce the issue! |
ksuprynowicz
changed the title
ksuprynowicz
force-pushed
the
fix/signal_proxy_crash
branch
from
d9d4b3a to
fe82904
Compare
ksuprynowicz
added
QA approved
HifiExperiments
approved these changes
Nov 21, 2024
HifiExperiments
added
CR approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing crashes when exiting domains that use signals in entity scripts.