Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fade out not working in forward rendering #1234

Merged
merged 2 commits into from
Nov 12, 2024
Merged

fix fade out not working in forward rendering #1234

merged 2 commits into from
Nov 12, 2024

Conversation

HifiExperiments
Copy link
Member

close #1233

@HifiExperiments HifiExperiments added bug Something isn't working needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested fix before release labels Nov 12, 2024
ksuprynowicz
ksuprynowicz approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@ksuprynowicz ksuprynowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine :)

@ksuprynowicz ksuprynowicz added CR approved This pull request has been successfully code reviewed and removed needs CR This pull request needs to be code reviewed labels Nov 12, 2024
@ksuprynowicz
Copy link
Member

Thank you!
I tested it and fixes the issue

@ksuprynowicz ksuprynowicz added QA approved This pull request has been successfully tested and removed needs QA This pull request needs to be tested labels Nov 12, 2024
@ksuprynowicz ksuprynowicz merged commit ad5b6d0 into overte-org:master Nov 12, 2024
6 checks passed
@HifiExperiments HifiExperiments deleted the forwardFade branch November 12, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksuprynowicz ksuprynowicz ksuprynowicz approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CR approved This pull request has been successfully code reviewed fix before release QA approved This pull request has been successfully tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avatars don't fade out on forward renderer.
2 participants
@HifiExperiments @ksuprynowicz