Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix access-after-delete on leaving domain with entity scripts #1230

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Fix access-after-delete on leaving domain with entity scripts #1230

merged 1 commit into from
Nov 10, 2024

Conversation

ksuprynowicz
Copy link
Member

Fixes #1228

@ksuprynowicz ksuprynowicz added the bug Something isn't working label Nov 9, 2024
@HifiExperiments HifiExperiments added the CR approved This pull request has been successfully code reviewed label Nov 10, 2024
@ksuprynowicz
Copy link
Member Author

I tested it with about exiting Ceon about 20 times and I'm not able to cause this crash anymore, so I think it works. More testing is always welcome though.

@ksuprynowicz ksuprynowicz added the needs QA This pull request needs to be tested label Nov 10, 2024
@daleglass daleglass merged commit e29310d into master Nov 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HifiExperiments HifiExperiments HifiExperiments approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CR approved This pull request has been successfully code reviewed needs QA This pull request needs to be tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash on unloading entity script
3 participants
@ksuprynowicz @HifiExperiments @daleglass