-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protocol changes -> master #1096
Conversation
…n mirrorMode != portal
Mirrors + Portals
Revert "Mirrors + Portals"
Revert "Revert "Mirrors + Portals""
Entity tags
Web Entity wantsKeyboardFocus
Improve model load priority
…ext recalculating too often
Automated entity property serialization
Text verticalAlignment, send entity property enums as uint8_t, fix text recalculating too often, fix textSize
from my side, this should be ready to merge now, unless anyone else wanted to include other protocol changes for the next release! personally, I don't think it needs its own CR/QA since each individual PR was reviewed and the whole thing will be tested again as part of the RC, and if any issues do arise I can fix them directly in master, but I leave that to others to decide |
I just want to add a small PR to disable voxel autodelete, but we can also do it after merging protocol changes into master. Before merging I think we should test it for a bit. |
I was meaning to do a new release candidate today. |
so...I have a fair number of PRs I've been working on that depend on various changes in this branch, and I'm also worried about conflicts piling up if it sits too long (there are already several new PRs against master that will lead to conflicts once merged). I'll also have a bit less time to work on things starting in a few weeks, so I'd love to get this wrapped up. do we have a plan/timeline for the upcoming release, or anything I could help with? or, since it's already been tagged, could we think about merging this sometime soonish? I think that'll be the best way to get people using and testing it anyways. removing the voxel autodelete could also come later, especially since #830 is not included in this (and in fact, that PR already includes the removal of the auto delete: https://github.com/overte-org/overte/pull/830/files#diff-637dfca649b67c61e00fd48f256591e8113cbca5cf791da6ff6e3e6d9c6dd303L1120) |
@HifiExperiments Can I merge it today? I'll do one last short round of testing before merging of course. |
This PR includes all of the following changes: