Skip to content

Commit

Permalink
Merge pull request #820 from HifiExperiments/shadowCull
Browse files Browse the repository at this point in the history
Respect cull face during shadow pass
  • Loading branch information
ksuprynowicz authored Mar 1, 2024
2 parents d589403 + 5c5480b commit 9284797
Show file tree
Hide file tree
Showing 5 changed files with 180 additions and 201 deletions.
2 changes: 1 addition & 1 deletion libraries/gpu/src/gpu/State.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ class GPUObject;
class State {
public:
State();
State(const State& state) : _values(state._values), _signature(state._signature), _stamp(state._stamp) {}
virtual ~State();

Stamp getStamp() const { return _stamp; }
Expand Down Expand Up @@ -464,7 +465,6 @@ class State {
const GPUObjectPointer gpuObject{};

protected:
State(const State& state);
State& operator=(const State& state);

Data _values;
Expand Down
3 changes: 0 additions & 3 deletions libraries/render-utils/src/HighlightEffect.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -477,10 +477,7 @@ void DrawHighlightTask::build(JobModel& task, const render::Varying& inputs, ren
auto shapePlumber = std::make_shared<ShapePlumber>();
{
auto state = std::make_shared<gpu::State>();
state->setDepthTest(true, true, gpu::LESS_EQUAL);
state->setColorWriteMask(false, false, false, false);


auto fadeEffect = DependencyManager::get<FadeEffect>();
initZPassPipelines(*shapePlumber, state, fadeEffect->getBatchSetter(), fadeEffect->getItemUniformSetter());
}
Expand Down
Loading

0 comments on commit 9284797

Please sign in to comment.