Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 557490fb7c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "Company": companyDict, | ||
| ] | ||
| if let data = try? JSONSerialization.data(withJSONObject: linksDict) { | ||
| return try? JSONDecoder().decode(Links.self, from: data) |
There was a problem hiding this comment.
The linksConfiguration loader returns try? JSONDecoder().decode(...) directly for the Developer/Company branch, so a decode failure exits the function immediately instead of falling back to Links, AppConfig, or AppConfig.plist. This is reachable when Info.plist includes partial Developer/Company dictionaries (for example, missing required AppStoreID in Links.Company), and it makes all link-derived values unexpectedly nil even if valid fallback config exists.
Useful? React with 👍 / 👎.
| links?.company.appStoreId | ||
| public static var appStoreReviewUrl: URL? { | ||
| guard let appStoreId else { return nil } | ||
| return URL(string: "itms-apps:itunes.apple.com/us/app/apple-store/id\(appStoreId)&action=write-review") |
There was a problem hiding this comment.
appStoreReviewUrl builds itms-apps:.../id<id>&action=write-review without a ? before the query parameter, so action=write-review is not encoded as a query string. In practice this can prevent opening the direct review flow and instead open an invalid or generic App Store target.
Useful? React with 👍 / 👎.
1 participant
No description provided.